Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs typo #355

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix docs typo #355

merged 1 commit into from
Oct 25, 2023

Conversation

m-bossart
Copy link
Collaborator

Fixes swapped descriptions of Simulation! and Simulation

@m-bossart m-bossart requested a review from rodrigomha October 24, 2023 22:36
Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@github-actions
Copy link
Contributor

Performance Results

Version Precompile Time
Main 4.620604173
This Branch 4.651907561
Version Run Time
Main-Build ResidualModel 10.865983909
Main-Execute ResidualModel 30.479012484
Main-Build MassMatrixModel 0.939656221
Main-Execute MassMatrixModel 33.460143521
This Branch-Build ResidualModel 10.962052616
This Branch-Execute ResidualModel 30.8442638
This Branch-Build MassMatrixModel 0.940748858
This Branch-Execute MassMatrixModel 32.853439699

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #355 (9c3b839) into main (012e68c) will increase coverage by 0.40%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   86.99%   87.39%   +0.40%     
==========================================
  Files          65       65              
  Lines        9048     8999      -49     
==========================================
- Hits         7871     7865       -6     
+ Misses       1177     1134      -43     
Flag Coverage Δ
unittests 87.39% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/simulation.jl 93.30% <ø> (+0.88%) ⬆️

... and 3 files with indirect coverage changes

@jd-lara jd-lara merged commit ef32fb4 into main Oct 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants